feat!: auto-enqueue public init nullifier for contracts with public functions (#20775) [v4-next backport]#21417
Closed
AztecBot wants to merge 3 commits intobackport-to-v4-next-stagingfrom
Conversation
ludamad
force-pushed
the
backport-to-v4-next-staging
branch
from
5c50c04 to
4eb8703
Compare
Resolved conflicts in: - docs/docs-developers/docs/resources/migration_notes.md: added new migration notes section - noir-projects/aztec-nr/aztec/src/macros/aztec.nr: adapted imports for v4-next (no offchain_receive) - noir-projects/noir-protocol-circuits/crates/types/src/constants.nr: added DOM_SEP__PUBLIC_INITIALIZATION_NULLIFIER - noir-projects/noir-protocol-circuits/crates/types/src/constants_tests.nr: updated HashedValueTester counts - yarn-project/end-to-end/src/composed/ha/e2e_ha_full.test.ts: dropped reloadKeystore test (not on v4-next)
v4-next has one fewer domain separator (no SINGLE_USE_CLAIM_NULLIFIER) than next did before the PR, so the counts are <51, 44> instead of <52, 45>.
ludamad
force-pushed
the
claudebox/backport-20775-auto-enqueue-init-nullifier
branch
from
030fdfe to
1f468dd
Compare
Collaborator
|
Closing as duplicate — superseded by a newer attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #20775 to v4-next.
Contract initialization now emits two separate nullifiers (private + public) instead of one, fixing a race condition where public functions could be called before initialization completes.
Cherry-pick conflicts resolved
offchain_receivemodule)DOM_SEP__PUBLIC_INITIALIZATION_NULLIFIERHashedValueTestercounts to<51, 44>(v4-next lacksSINGLE_USE_CLAIM_NULLIFIERthat next has)reloadKeystoretest context (doesn't exist on v4-next)Commit structure
ClaudeBox log: https://claudebox.work/s/486d6d3ab82ec418?run=1